Synchronize Collection::add with doctrine/collections
#560
Conversation
|
What about older versions? I see true in 1.8.0 |
Oh, do we have to duplicate the stub then ? |
|
We need conditional including of different stubs based on the version. In a StubFilesExtension. |
VincentLanglet
force-pushed
the
addCollection
branch
from
835848d to
3d6353b
Compare
Done |
| @@ -59,6 +61,13 @@ public function getFiles(): array | |||
| $files[] = $stubsDir . '/ServiceEntityRepository.stub'; | |||
| } | |||
|
|
|||
| $collectionVersion = InstalledVersions::getVersion('doctrine/dbal'); | |||
There was a problem hiding this comment.
Please check that InstalledVersions class exists.
There was a problem hiding this comment.
Strictly speaking, we should even catch OutOfBoundsException in case dbal is not installed: https://getcomposer.org/doc/07-runtime.md#knowing-the-version-of-package-x
There was a problem hiding this comment.
Oh damn, and the check should be about 'doctrine/collections' not 'doctrine/dbal'.
I fixed it and added a class_exists check and the try/catch of OutOfBoundsException.
VincentLanglet
force-pushed
the
addCollection
branch
from
4193c2a to
6ff7fcc
Compare
VincentLanglet
force-pushed
the
addCollection
branch
from
6ff7fcc to
a419021
Compare
|
Thank you. |
|
I messed up and target 1.4.x instead of 1.3.x. Should I reopen a PR on 1.3.x @ondrejmirtes ? |
|
No, you'll have to wait for release alongside PHPStan 1.11 😊 shouldn't be too far off |
Hi,
Collection::addreturnsvoidand nottrueaccording to doctrine/collectionshttps://github.com/doctrine/collections/blob/9b9c38a3eff3c7477989129b096d21e2b1710ee0/src/Collection.php#L34-L42