Skip to content

More fixes #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 29, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion skeleton/README.md.twig
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ This is a basic skeleton to help you start building a phpBB extension. Customise
## Extension Development Guide

New to phpBB extension development?
Start here: [phpBB Extension Development Guide](https://area51.phpbb.com/docs/dev/3.3.x/extensions/index.html)
Start here: [phpBB Extension Development Guide](https://area51.phpbb.com/docs/dev/{{ skeleton_version_compare(REQUIREMENTS.phpbb_version_min, "4.0", "<") ? '3.3.x' : 'master' }}/extensions/index.html)

## License

Expand Down
2 changes: 0 additions & 2 deletions skeleton/migrations/install_sample_data.php.twig
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ class install_sample_data extends \phpbb\db\migration\migration
/**
* Add, update or delete data stored in the database during extension installation.
*
* https://area51.phpbb.com/docs/dev/3.3.x/migrations/data_changes.html
{% if COMPONENT.migration %}
* config.add: Add config data.
* config.update: Update config data.
Expand Down Expand Up @@ -99,7 +98,6 @@ class install_sample_data extends \phpbb\db\migration\migration
* and only needs to be used to perform custom un-installation changes, such as to revert
* changes made by custom functions called in update_data.
*
* https://area51.phpbb.com/docs/dev/3.3.x/migrations/data_changes.html
* config.add: Add config data.
* config.update: Update config data.
* config.remove: Remove config.
Expand Down
2 changes: 0 additions & 2 deletions skeleton/migrations/install_sample_schema.php.twig
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ class install_sample_schema extends \phpbb\db\migration\migration
/**
* Update database schema.
*
* https://area51.phpbb.com/docs/dev/3.3.x/migrations/schema_changes.html
* add_tables: Add tables
* drop_tables: Drop tables
* add_columns: Add columns to a table
Expand Down Expand Up @@ -69,7 +68,6 @@ class install_sample_schema extends \phpbb\db\migration\migration
* Revert database schema changes. This method is almost always required
* to revert the changes made above by update_schema.
*
* https://area51.phpbb.com/docs/dev/3.3.x/migrations/schema_changes.html
* add_tables: Add tables
* drop_tables: Drop tables
* add_columns: Add columns to a table
Expand Down
5 changes: 2 additions & 3 deletions skeleton/tests/controller/main_test.php.twig
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,8 @@ class main_test extends \phpbb_test_case
->getMock();

// Set {{ LANGUAGE.object }}->lang() to return any arguments sent to it
${{ LANGUAGE.object }}->expects(self::any())
->method('lang')
->will(self::returnArgument(0));
${{ LANGUAGE.object }}->method('lang')
->will($this->returnArgument(0));

/** @var \phpbb\controller\helper|\PHPUnit\Framework\MockObject\MockObject $controller_helper Mock the controller helper class */
$controller_helper = $this->getMockBuilder('\phpbb\controller\helper')
Expand Down