Skip to content

Fix up rounding for small values. #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 10, 2025
Merged

Fix up rounding for small values. #18

merged 2 commits into from
Mar 10, 2025

Conversation

dereuromark
Copy link
Contributor

Fix up issues found in spryker/decimal-object#25

Thanks to AI I got a few leads on what the issues are.
With more test coverage this should have fixed the issues.

Let me know if there are any cases left.
@gahorth

Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.16%. Comparing base (2f95de3) to head (eeb19aa).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #18      +/-   ##
============================================
+ Coverage     93.96%   94.16%   +0.20%     
- Complexity      101      103       +2     
============================================
  Files             1        1              
  Lines           232      240       +8     
============================================
+ Hits            218      226       +8     
  Misses           14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dereuromark dereuromark merged commit a9421cd into master Mar 10, 2025
5 checks passed
@dereuromark dereuromark deleted the rounding-fixes branch March 10, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant