Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Aug 21, 2025

The login modal was positioned at the bottom of the screen on mobile devices instead of being properly centered, creating a poor user experience. This was particularly problematic on smaller viewports where the modal appeared to be "stuck" at the bottom.

Problem

On mobile devices, the HeroUI Modal component was using default positioning which resulted in bottom placement. This made the login form difficult to access and provided inconsistent UX compared to desktop.

Solution

Added the placement="center" prop to the Modal component in login-modal.tsx. This leverages HeroUI's built-in positioning system which provides:

  • "center" - Centers the modal in the viewport (our fix)
  • "auto" - Default behavior (was causing the issue)
  • "top", "top-center", "bottom", "bottom-center" - Other positioning options
// Before
<Modal isOpen={isOpen} onClose={onClose}>

// After  
<Modal isOpen={isOpen} onClose={onClose} placement="center">

Testing

  • ✅ Verified on multiple mobile viewport sizes (320x568, 375x667)
  • ✅ All 457 unit tests passing
  • ✅ Build and linting successful
  • ✅ Desktop functionality preserved
  • ✅ Login flow works correctly on both mobile and desktop

Screenshots

Before (❌ Modal stuck at bottom):
Mobile Login Modal Issue

After (✅ Modal properly centered):
Mobile Login Modal Fixed

The fix also verified that other reported mobile issues (tab header wrapping and basic info form scrolling) were already working correctly without additional changes needed.

Fixes #123.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • download.cypress.io

If you need me to access, download, or install something from one of these locations, you can either:


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: RBN-Apps <80348653+RBN-Apps@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix Edit Page on Mobile Fix login modal positioning on mobile devices Aug 21, 2025
Copilot AI requested a review from RBN-Apps August 21, 2025 15:07
Copilot finished work on behalf of RBN-Apps August 21, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Edit Page on Mobile

2 participants