Dora dashboard final #43
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed ExampleComponent to DashboardComponent and ExampleFetchComponent to FetchMetricsComponent. Updated imports and exports accordingly, removed obsolete index files, and cleaned up unused types from the backend service types file.
Introduced tests for the dora-dashboard-backend plugin (plugin, router, and service) and the dora-dashboard frontend components (DashboardComponent, DoraDashboard, FetchMetricsComponent, and MetricChart).
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
Minor changes so yarn prettier runs without issue
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces extensive testing and cleanup for the
dora-dashboard-backendanddora-dashboardplugins, along with renaming and restructuring components. Key changes include adding comprehensive test coverage for backend services, routers, and frontend components, as well as removing unused code and updating component names for clarity.Backend Improvements
Enhanced Test Coverage for Backend Services and Routers:
workspaces/dora-explorer/plugins/dora-dashboard-backend/src/plugin.test.ts: Added tests to validate the initialization logic and error handling forcreateDoraServiceandcreateRouter. This ensures robustness in plugin initialization and backend service interactions.workspaces/dora-explorer/plugins/dora-dashboard-backend/src/router.test.ts: Added tests forcreateRouter, covering various scenarios such as missing query parameters, error handling, and data retrieval for metrics and project names.workspaces/dora-explorer/plugins/dora-dashboard-backend/src/services/DoraService/createDoraService.test.ts: Added tests forcreateDoraService, verifying database interactions and error handling for unsupported metrics and aggregations.Code Cleanup:
workspaces/dora-explorer/plugins/dora-dashboard-backend/src/services/DoraService/types.ts: Removed unused interfaces (TodoItemandTodoListService) that were unrelated to the DORA metrics functionality.Frontend Enhancements
Improved Test Coverage for Dashboard Components:
workspaces/dora-explorer/plugins/dora-dashboard/src/components/DashboardComponent/DashboardComponent.test.tsx: Added tests for rendering the dashboard title and metric labels, ensuring the component displays expected content.workspaces/dora-explorer/plugins/dora-dashboard/src/components/DoraDashboard.test.tsx: Added comprehensive tests forDoraDashboard, covering loading states, error handling, chart rendering, and export functionality (PDF, SVG, PNG).Component Renaming and Restructuring:
ExampleComponenttoDashboardComponentand updated related imports and exports for better clarity and alignment with functionality. [1] [2]ExampleFetchComponentreferences toFetchMetricsComponentinDoraDashboard.Removed Obsolete Components:
ExampleComponentandExampleFetchComponent, as they were no longer relevant to the current implementation. [1] [2]