Fix tab bar drag-drop issues in between panes #2266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
LGTM . Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following changes:
1st Commit:- Earlier it was not possible to drop a dragged tab over the editor area. This commit fixes that issue. Now users can drag a tab from one pane and drop it in the editor area of the other pane and the tab successfully gets placed.
2nd Commit:- When a tab was dragged from one pane to the other pane, the dragged tab now becomes active. Earlier it was not possible.
3rd Commit:- Earlier, after dragging dropping tabs, sometimes tab bar becomes unresponsive. this was because _registerHandlers was not attaching all the events properly. fixed that.
4th commit:- Just updated the pane border styling.
5th commit:- Sometimes when a tab was dragged from one pane to other pane, then a placeholder(temporary tab) used to appear on the first pane from where tab was dragged. Fixed that. This issue mainly appeared because when dragging a click event also gets fired because of which a placeholder tab was added.
6th commit:- just some styling changes and made the dirty icon, file directory name, and close icon all aligned