Fix sidebar button titles & Layout Semantics #1285
Open
+62
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change `<div>` to `<header>` in `layout_component.html.erb` for better structure. - Update `<aside>` to `<nav>` in `sidebar_component.html.erb` to reflect navigation semantics. - Replace `<div>` with `<header>` in `header_component.html.erb` for improved accessibility. - Remove unused localization key `navigation` from `en.yml` and `fr.yml` for consistency.
- Adjust the formatting of the `flashes` div in `layout_component.html.erb` for better code clarity and maintainability.
…improve accessibility checks
…mproved semantic accuracy
Code Metrics Report
Code coverage of files in pull request scope (100.0%)
Reported by octocov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do and why?
• Consolidated localization keys: Replaced separate title and aria_label keys with unified label keys for navbar buttons
• Updated components: Modified sidebar_component.html.erb and layout_component.html.erb to use the new key structure
• Updated translations: Updated both en.yml and fr.yml locale files to reflect the new consistent key structure
• Fixed tests: Updated system tests in groups_test.rb and projects_test.rb to use the new localization keys
• Updated html tags to ensure proper semantic html
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other pull requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
• Navbar buttons display correct tooltips and aria-labels
• System tests pass with updated localization keys
• Both English and French translations are consistent
PR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.