Feat: Refresh controller #1233
Draft
Feat: Refresh controller #1233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
joshsadam
force-pushed
the
feat/refresh_controller
branch
from
3f8c522 to
1419806
Compare
joshsadam
force-pushed
the
feat/refresh_controller
branch
from
b02be8b to
1d9bd17
Compare
This comment has been minimized.
This comment has been minimized.
joshsadam
force-pushed
the
feat/refresh_controller
branch
from
61dce43 to
9143691
Compare
This comment has been minimized.
This comment has been minimized.
joshsadam
force-pushed
the
feat/refresh_controller
branch
2 times, most recently
from
725ca83 to
03959c0
Compare
…layed when using turbo_stream_from
joshsadam
force-pushed
the
feat/refresh_controller
branch
from
59d87ad to
612367d
Compare
This comment has been minimized.
This comment has been minimized.
Code Metrics Report
Code coverage of files in pull request scope (98.9%)
Reported by octocov |
…ct if the sample was transferred not on creation
ericenns
force-pushed
the
feat/refresh_controller
branch
from
dc06ca6 to
cae7e88
Compare
Refactors the refresh controller to handle turbo stream messages more robustly by checking for the presence of `action="refresh"` and ensures the event data starts with "
joshsadam
force-pushed
the
feat/refresh_controller
branch
2 times, most recently
from
9769c21 to
752c623
Compare
Adds a dismiss method to the refresh controller and a refresh method to reload the page. Updates the samples index view to use the new RefreshNoticeComponent for displaying refresh notifications. Localizes refresh notice messages in English and French.
Removes Flowbite-style comment from the refresh notice component. Updates the refresh controller to improve Turbo Stream event handling, including methods for showing and hiding the refresh notice, and checks for refresh actions more robustly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do and why?
Describe in detail what your merge request does and why.
This PR updates the way broadcasting refreshes when a sample is changed in a group or project. Now, when a sample is changed, the broadcasted change displays an alert dialogue to users who are on the same page:
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other pull requests.
Samples were deleted in the window on the right, update was sent to the browser on the left.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
PR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.