Skip to content

Update for 4.40.23081 #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

sparajoy1
Copy link

@sparajoy1 sparajoy1 commented Sep 2, 2024

doing a brief update for the patches for 4.40 that released this month. still in progress but this is as far as i've gotten today.

changes:

  • allow info panel on random screensaver: FullScreenDragonPowerView -> BookCoverDragonPowerView
  • don't uppercase header/footer: offset 282 -> 298
  • don't uppercase header/footer + change page number text: offset 282 -> 298
  • allow rotation on all devices: readingmenuview offset 236 -> 238
    ETA:
  • customize comfort light settings: base address 0xE82E2C -> 0xE9841c
  • remove forgot pin button: base address 0x1972E04 -> 0x1C3E4E7
  • increase size of kepub chapter progress chart: base address 0x196E0F6 -> 0x1C20EAC

not tested/failed:

  • my 24 line spacing
  • remove pdf map widget

changes:
- allow info panel on random screensaver: FullScreenDragonPowerView -> BookCoverDragonPowerView
- don't uppercase header/footer: offset 282 -> 298
- don't uppercase header/footer + change page number text: offset 282 -> 298

not tested/failed:
- customize comfortlight settings
- allow rotation on all devices
- my 24 line spacing
- remove pdf map widget
- increase size of kepub chapter chart
@pgaskin
Copy link
Owner

pgaskin commented Sep 2, 2024

Thanks for working on this! I'll review it soon.

A few hints for the other ones:

  • My qrc2zip command and armqrc.py script will extract CSS offsets.
  • ComfortLight should be as simple as finding the QTime constructor and updating one or two offsets, unless they've made major changes.
  • PDF map widget will be more work if it's more than the usual case where you look for the x-refs to the update bx thunk and replace it with the bx thunk for QWidget::hide. Also, this patch should probably have a note saying it only applies to the Adobe Reader now that foxit is used in some cases.
  • 24 line spacing will need a rewrite; it's easier than trying to update it incrementally. It basically works by ignoring/replacing all the existing code and replacing it with new code to build a list of sizes.

You've probably noticed that the CI is inactive right now; I'll be fixing that later.

@sparajoy1
Copy link
Author

Yeah I was planning on trying to check the CSS after dinner!

I did also compile a testdata tarball for 4.40.23081 if that's handy for you at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants