net-mgmt/pfSense-pkg-arpwatch: Add missing dot between hostname and domain #1408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omain
I saw arpwatch notices here the hostname was missing a dot:
[hostname=pear, domain=example.com]
Subject: pearexample.com - Arpwatch Notification : changed ethernet address
The bug is in sendmail_proxy.php is was surprisingly resistent
to local patching. Today I tracked down that it's created at run
time by pfSense-pkg-arpwatch. I tracked it to 99368e3:
- $send_subject = "{$config['system']['hostname']}.{$config['system']['domain']} - Arpwatch Notification : {$subject[1]}";
+ $send_subject = config_get_path('system/hostname') . config_get_path('system/domain') . " - Arpwatch Notification : {$subject[1]}";
This fix for this regression is to add a string with the dot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw arpwatch notices where the hostname was missing a dot:
The bug is in sendmail_proxy.php was surprisingly resistant to local patching. Today I tracked down that it's created at run time by pfSense-pkg-arpwatch. I tracked it to 99368e3:
- $send_subject = "{$config['system']['hostname']}.{$config['system']['domain']} - Arpwatch Notification : {$subject[1]}";
+ $send_subject = config_get_path('system/hostname') . config_get_path('system/domain') . " - Arpwatch Notification : {$subject[1]}";
This fix for this regression is to add a string with the dot.