net/pfSense-pkg-pfBlockerNG-devel: additional logging for MaxMind update failures #1342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added logging and fixed DCC cron job to run every Thursday instead of running on the 4-10th of the month.
|
I don't know if this would be of benefit. If the user enters the Account and Key, I don't see a benefit to log it each time cron runs? |
I've had issues on multiple installs where it would not update the local file because it thought it already existed. By adding this log message I was able to see why the update wasn't working and trigger it manually via the PHP DC command. A simple one-liner to the log to show why the update didn't happen seems rather useful for a very small trade-off of log size increase. |
marcos-ng
changed the title
marcos-ng
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds specific messages to show that the files either existed or that the API key is empty.
Without these messages, the action just silently fails without logging anything to the window/log.