-
Notifications
You must be signed in to change notification settings - Fork 126
Fix bugs for rotor with supports #1195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1195 +/- ##
==========================================
- Coverage 82.91% 75.60% -7.31%
==========================================
Files 39 38 -1
Lines 8247 8494 +247
==========================================
- Hits 6838 6422 -416
- Misses 1409 2072 +663
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|


Resolves #1189
This pull request addresses three main issues related to the rotor model with supports:
1. Allow multiple bearing elements on the same shaft node:

Previously, it was not possible to attach more than two bearing elements to the same shaft node. Adjustments have been made to enable this behavior.
2. Fix error in run_ucs when using supports:⚠️ This fix still needs further verification.
An error was occurring in the
run_ucsfunction when the model included supports in the bearings. Specific corrections were implemented to handle this case.3. Fix error in
run_freq_responsewhen speed is zero:In a specific case involving supports, the solver was returning eigenvalues equal to zero. Because the speed being analyzed was also zero, this caused the
transfer_matrixto contain NaN values. A fix was applied to handle this scenario and prevent such behavior.