Fix opening_hour factory to default close_day to start_day #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The factory was hardcoding close_day to 1 (Monday), which caused tests to fail when creating same-day opening hours for other days. The Friday prayer break test was failing because it incorrectly treated Friday hours as overnight hours ending on Monday. This fix ensures close_day defaults to start_day unless explicitly overridden, making same-day hours the default behavior. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The factory was hardcoding close_day to 1 (Monday), which caused tests to fail when creating same-day opening hours for other days. The Friday prayer break test was failing because it incorrectly treated Friday hours as overnight hours ending on Monday.
This fix ensures close_day defaults to start_day unless explicitly overridden, making same-day hours the default behavior.
🤖 Generated with Claude Code