K8SPS-265 add special characters #951

nmarukovich · 2025-06-16T18:14:15Z

CHANGE DESCRIPTION

Problem:

Cause:
Short explanation of the root cause of the issue if applicable.

Solution:
extending password strength with specific characters.

CHECKLIST

Jira

Is the Jira ticket created and referenced properly?
Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

Is an E2E test/test case added for the new feature/change?
Are unit tests added where appropriate?

Config/Logging/Testability

Are all needed new/changed options added to default YAML files?
Are all needed new/changed options added to the Helm Chart?
Did we add proper logging messages for operator actions?
Did we ensure compatibility with the previous version or cluster upgrade process?
Does the change support oldest and newest supported PS version?
Does the change support oldest and newest supported Kubernetes version?

github-actions · 2025-06-16T18:14:35Z

build/router-entrypoint.sh

@@ -6,18 +6,23 @@ ROUTER_DIR=${ROUTER_DIR:-/tmp/router}
 OPERATOR_USER=${OPERATOR_USER:-operator}
 NAMESPACE=$(</var/run/secrets/kubernetes.io/serviceaccount/namespace)

+urlencode() {
+  python3 -c 'import urllib.parse, sys; print(urllib.parse.quote(sys.argv[1]))' "$1"


[shfmt] _{reported by reviewdog 🐶}

Suggested change

python3 -c 'import urllib.parse, sys; print(urllib.parse.quote(sys.argv[1]))' "$1"

python3 -c 'import urllib.parse, sys; print(urllib.parse.quote(sys.argv[1]))' "$1"

github-actions · 2025-06-16T18:14:35Z

build/router_readiness_check.sh

@@ -1,15 +1,20 @@
 #!/bin/bash

+urlencode() {
+  python3 -c 'import urllib.parse, sys; print(urllib.parse.quote(sys.argv[1]))' "$1"


[shfmt] _{reported by reviewdog 🐶}

Suggested change

python3 -c 'import urllib.parse, sys; print(urllib.parse.quote(sys.argv[1]))' "$1"

python3 -c 'import urllib.parse, sys; print(urllib.parse.quote(sys.argv[1]))' "$1"

github-actions · 2025-06-16T18:14:35Z

build/router_startup_check.sh

@@ -1,7 +1,12 @@
 #!/bin/bash

+urlencode() {
+  python3 -c 'import urllib.parse, sys; print(urllib.parse.quote(sys.argv[1]))' "$1"


[shfmt] _{reported by reviewdog 🐶}

Suggested change

python3 -c 'import urllib.parse, sys; print(urllib.parse.quote(sys.argv[1]))' "$1"

python3 -c 'import urllib.parse, sys; print(urllib.parse.quote(sys.argv[1]))' "$1"

github-actions · 2025-06-16T18:16:08Z

e2e-tests/functions

+  local user="${1:-root}"
+  kubectl -n "${NAMESPACE}" get secret test-secrets -o jsonpath="{.data.${user}}" | base64 --decode


[shfmt] _{reported by reviewdog 🐶}

Suggested change

local user="${1:-root}"

kubectl -n "${NAMESPACE}" get secret test-secrets -o jsonpath="{.data.${user}}" | base64 --decode

local user="${1:-root}"

kubectl -n "${NAMESPACE}" get secret test-secrets -o jsonpath="{.data.${user}}" | base64 --decode

…-mysql-operator into K8SPS-265_special

github-actions · 2025-06-17T13:58:59Z

build/orc-entrypoint.sh

-sed -r "s|^[#]?password=.*$|password=${TOPOLOGY_PASSWORD:-$ORC_TOPOLOGY_PASSWORD}|" "${ORC_CONF_PATH}/orc-topology.cnf" >"${temp}"
+
+ESCAPED_PASSWORD=$(printf '%s' "${TOPOLOGY_PASSWORD:-$ORC_TOPOLOGY_PASSWORD}" | sed -e 's/[&"\\]/\\&/g')
+ESCAPED_PASSWORD="\"${ESCAPED_PASSWORD}\""  # Wrap in double quotes for .cnf


[shfmt] _{reported by reviewdog 🐶}

Suggested change

ESCAPED_PASSWORD="\"${ESCAPED_PASSWORD}\"" # Wrap in double quotes for .cnf

ESCAPED_PASSWORD="\"${ESCAPED_PASSWORD}\"" # Wrap in double quotes for .cnf

github-actions · 2025-06-17T13:58:59Z

build/orc-entrypoint.sh

+  -e "s|^[#]?user=.*$|user=${TOPOLOGY_USER}|" \
+  -e "s|^[#]?password=.*$|password=${ESCAPED_PASSWORD}|" \
+  "${ORC_CONF_PATH}/orc-topology.cnf" > "${temp}"


[shfmt] _{reported by reviewdog 🐶}

Suggested change

-e "s|^[#]?user=.*$|user=${TOPOLOGY_USER}|" \

-e "s|^[#]?password=.*$|password=${ESCAPED_PASSWORD}|" \

"${ORC_CONF_PATH}/orc-topology.cnf" > "${temp}"

-e "s|^[#]?user=.*$|user=${TOPOLOGY_USER}|" \

-e "s|^[#]?password=.*$|password=${ESCAPED_PASSWORD}|" \

"${ORC_CONF_PATH}/orc-topology.cnf" >"${temp}"

gkech · 2025-06-23T08:12:49Z

pkg/secret/secret.go

@@ -45,7 +45,8 @@ const (
 	passwordMinLen = 16
 	passSymbols    = "ABCDEFGHIJKLMNOPQRSTUVWXYZ" +
 		"abcdefghijklmnopqrstuvwxyz" +
-		"0123456789"
+		"0123456789" +
+		"!$%&()*+,-.<=>?@[]^_{}~#"


For any characters that we omitted from the password generation, I recommend we add a small godoc with some notes. It will help a lot.

gkech · 2025-06-23T08:20:50Z

e2e-tests/tests/demand-backup/01-deploy-operator.yaml

@@ -10,7 +10,6 @@ commands:

      apply_s3_storage_secrets
      deploy_operator
-      deploy_non_tls_cluster_secrets


So we are removing this cause the operator does not trigger the password generation if the key/value pair exists, right?

Because I want operator generate random passwords and we use it in our tests. (now we use passwords from predefined file and it's like root_password )

github-actions · 2025-07-02T13:14:21Z

build/ps-entrypoint.sh

+		| sed 's/'\''/'\\\\\''/g' \
+		| sed 's/"/\\\"/g'
+}
+
 MYSQL_VERSION=$(mysqld -V | awk '{print $3}' | awk -F'.' '{print $1"."$2}')

 if [[ "$MYSQL_VERSION" != '8.0' ]] && [[ "${MYSQL_VERSION}" != '8.4' ]]; then


[shfmt] _{reported by reviewdog 🐶}

Suggested change

if [[ "$MYSQL_VERSION" != '8.0' ]] && [[ "${MYSQL_VERSION}" != '8.4' ]]; then

if [[ $MYSQL_VERSION != '8.0' ]] && [[ ${MYSQL_VERSION} != '8.4' ]]; then

gkech · 2025-07-15T07:57:33Z

the e2e are faiing for me. e.g. I tried the gr-users test and the operator is logging an error which indicates that the MySQL connection string has illegal characters.

sample log:

025-07-15T07:53:55.618Z ERROR failed to update status {"controller": "ps-controller", "controllerGroup": "ps.percona.com", "controllerKind": "PerconaServerMySQL", "PerconaServerMySQL": {"name":"gr-users","namespace":"kuttl-test-equipped-spider"}, "namespace": "kuttl-test-equipped-spider", "name": "gr-users", "reconcileID": "0c078cfc-152c-4f18-99ac-76bd1a2c79c4", "error": "check if GR is ready: check cluster status from gr-users-mysql-1: stdout: , stderr: Cannot set LC_ALL to locale en_US.UTF-8: No such file or directory\nInvalid URI: Illegal character [^] found at position 15\n: command terminated with exit code 1", "errorVerbose": "command terminated with exit code 1\nstdout: , stderr: Cannot set LC_ALL to locale en_US.UTF-8: No such file or directory\nInvalid URI: Illegal character [^] found at position 15\n\ngithub.com/percona/percona-server-mysql-operator/pkg/mysqlsh.

K8SPS-265 add special characters

81a3dca

pull-request-size bot added the size/L 100-499 lines label Jun 16, 2025

github-actions bot reviewed Jun 16, 2025

View reviewed changes

nmarukovich and others added 2 commits June 16, 2025 20:14

delete unused

c3366a9

Merge branch 'main' into K8SPS-265_special

3b0ded3

github-actions bot reviewed Jun 16, 2025

View reviewed changes

add # to specific symbols list

eb31c2d

nmarukovich marked this pull request as ready for review June 17, 2025 09:42

nmarukovich requested review from jvpasinatto, eleo007, valmiranogueira, hors, egegunes, pooknull and gkech as code owners June 17, 2025 09:42

nmarukovich and others added 5 commits June 17, 2025 11:42

Merge branch 'main' into K8SPS-265_special

44b9a90

fix

55033b8

Merge branch 'K8SPS-265_special' of github.com:percona/percona-server…

293e890

…-mysql-operator into K8SPS-265_special

Merge branch 'main' into K8SPS-265_special

b380d88

fix PR suggestions and conflict

242a4f7

github-actions bot reviewed Jun 17, 2025

View reviewed changes

Merge branch 'main' into K8SPS-265_special

0976cfe

gkech reviewed Jun 23, 2025

View reviewed changes

gkech and others added 3 commits June 23, 2025 11:28

Merge branch 'main' into K8SPS-265_special

fdbb8b1

Merge branch 'main' into K8SPS-265_special

a1199db

add escape characters

714180e

github-actions bot reviewed Jul 2, 2025

View reviewed changes

nmarukovich requested a review from gkech July 2, 2025 14:17

hors and others added 2 commits July 2, 2025 20:41

Merge branch 'main' into K8SPS-265_special

4f07f91

Merge branch 'main' into K8SPS-265_special

ff54297

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

K8SPS-265 add special characters #951

K8SPS-265 add special characters #951

nmarukovich commented Jun 16, 2025 •

edited

Loading

Uh oh!

github-actions bot Jun 16, 2025

Uh oh!

github-actions bot Jun 16, 2025

Uh oh!

github-actions bot Jun 16, 2025

Uh oh!

github-actions bot Jun 16, 2025

Uh oh!

github-actions bot Jun 17, 2025

Uh oh!

github-actions bot Jun 17, 2025

Uh oh!

gkech Jun 23, 2025

Uh oh!

gkech Jun 23, 2025

Uh oh!

nmarukovich Jun 30, 2025

Uh oh!

github-actions bot Jul 2, 2025

Uh oh!

gkech commented Jul 15, 2025 •

edited

Loading

Uh oh!

Uh oh!

	python3 -c 'import urllib.parse, sys; print(urllib.parse.quote(sys.argv[1]))' "$1"
	python3 -c 'import urllib.parse, sys; print(urllib.parse.quote(sys.argv[1]))' "$1"

		local user="${1:-root}"
		kubectl -n "${NAMESPACE}" get secret test-secrets -o jsonpath="{.data.${user}}" \| base64 --decode

	ESCAPED_PASSWORD="\"${ESCAPED_PASSWORD}\"" # Wrap in double quotes for .cnf
	ESCAPED_PASSWORD="\"${ESCAPED_PASSWORD}\"" # Wrap in double quotes for .cnf

	if [[ "$MYSQL_VERSION" != '8.0' ]] && [[ "${MYSQL_VERSION}" != '8.4' ]]; then
	if [[ $MYSQL_VERSION != '8.0' ]] && [[ ${MYSQL_VERSION} != '8.4' ]]; then

K8SPS-265 add special characters #951

Are you sure you want to change the base?

K8SPS-265 add special characters #951

Conversation

nmarukovich commented Jun 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CHANGE DESCRIPTION

CHECKLIST

Uh oh!

github-actions bot Jun 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

gkech Jun 23, 2025

Choose a reason for hiding this comment

Uh oh!

gkech Jun 23, 2025

Choose a reason for hiding this comment

Uh oh!

nmarukovich Jun 30, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 2, 2025

Choose a reason for hiding this comment

Uh oh!

gkech commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

nmarukovich commented Jun 16, 2025 •

edited

Loading

gkech commented Jul 15, 2025 •

edited

Loading