K8SPS-421: Add keyring vault support #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open

egegunes wants to merge 6 commits into main from K8SPS-421

+1,412 −275

Open

K8SPS-421: Add keyring vault support #938

Merge branch 'main' into K8SPS-421

GitHub Actions / shellcheck failed Jun 16, 2025 in 1s

reviewdog [shellcheck] report

reported by reviewdog 🐶

Findings (11)

build/ps-entrypoint.sh|61 col 6| ShellCheck can't follow non-constant source. Use a directive to specify location.
build/ps-entrypoint.sh|220 col 22| Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
build/ps-entrypoint.sh|236 col 34| Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
build/ps-entrypoint.sh|236 col 70| Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
build/ps-entrypoint.sh|294 col 30| Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
build/ps-entrypoint.sh|376 col 22| Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
build/ps-entrypoint.sh|424 col 2| cluster_name appears unused. Verify use (or export if used externally).
build/run-restore.sh|50 col 72| Double quote to prevent globbing and word splitting.
e2e-tests/vars.sh|8 col 32| test_name is referenced but not assigned.
e2e-tests/vars.sh|28 col 1| date appears unused. Verify use (or export if used externally).
e2e-tests/vars.sh|30 col 30| Note that A && B || C is not if-then-else. C may run when A is true.

Filtered Findings (0)

Annotations

Check warning on line 61 in build/ps-entrypoint.sh

github-actions / shellcheck

[shellcheck] build/ps-entrypoint.sh#L61 <ShellCheck.SC1090>

ShellCheck can't follow non-constant source. Use a directive to specify location.

Raw output


            ./build/ps-entrypoint.sh:61:6: warning: ShellCheck can't follow non-constant source. Use a directive to specify location. (ShellCheck.SC1090)

Check warning on line 220 in build/ps-entrypoint.sh

github-actions / shellcheck

[shellcheck] build/ps-entrypoint.sh#L220 <ShellCheck.SC2166>

Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.

Raw output


            ./build/ps-entrypoint.sh:220:22: warning: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. (ShellCheck.SC2166)

Check warning on line 236 in build/ps-entrypoint.sh

github-actions / shellcheck

[shellcheck] build/ps-entrypoint.sh#L236 <ShellCheck.SC2166>

Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.

Raw output


            ./build/ps-entrypoint.sh:236:34: warning: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. (ShellCheck.SC2166)

Check warning on line 236 in build/ps-entrypoint.sh

github-actions / shellcheck

[shellcheck] build/ps-entrypoint.sh#L236 <ShellCheck.SC2166>

Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.

Raw output


            ./build/ps-entrypoint.sh:236:70: warning: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. (ShellCheck.SC2166)

Check warning on line 294 in build/ps-entrypoint.sh

github-actions / shellcheck

[shellcheck] build/ps-entrypoint.sh#L294 <ShellCheck.SC2166>

Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.

Raw output


            ./build/ps-entrypoint.sh:294:30: warning: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. (ShellCheck.SC2166)

Check warning on line 376 in build/ps-entrypoint.sh

github-actions / shellcheck

[shellcheck] build/ps-entrypoint.sh#L376 <ShellCheck.SC2166>

Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.

Raw output


            ./build/ps-entrypoint.sh:376:22: warning: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. (ShellCheck.SC2166)

Check warning on line 424 in build/ps-entrypoint.sh

github-actions / shellcheck

[shellcheck] build/ps-entrypoint.sh#L424 <ShellCheck.SC2034>

cluster_name appears unused. Verify use (or export if used externally).

Raw output


            ./build/ps-entrypoint.sh:424:2: warning: cluster_name appears unused. Verify use (or export if used externally). (ShellCheck.SC2034)

Check notice on line 50 in build/run-restore.sh

github-actions / shellcheck

[shellcheck] build/run-restore.sh#L50 <ShellCheck.SC2086>

Double quote to prevent globbing and word splitting.

Raw output


            ./build/run-restore.sh:50:72: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)

Check warning on line 8 in e2e-tests/vars.sh

github-actions / shellcheck

[shellcheck] e2e-tests/vars.sh#L8 <ShellCheck.SC2154>

test_name is referenced but not assigned.

Raw output


            ./e2e-tests/vars.sh:8:32: warning: test_name is referenced but not assigned. (ShellCheck.SC2154)

Check warning on line 28 in e2e-tests/vars.sh

github-actions / shellcheck

[shellcheck] e2e-tests/vars.sh#L28 <ShellCheck.SC2034>

date appears unused. Verify use (or export if used externally).

Raw output


            ./e2e-tests/vars.sh:28:1: warning: date appears unused. Verify use (or export if used externally). (ShellCheck.SC2034)

Check notice on line 30 in e2e-tests/vars.sh

github-actions / shellcheck

[shellcheck] e2e-tests/vars.sh#L30 <ShellCheck.SC2015>

Note that A && B || C is not if-then-else. C may run when A is true.

Raw output


            ./e2e-tests/vars.sh:30:30: info: Note that A && B || C is not if-then-else. C may run when A is true. (ShellCheck.SC2015)

View more details on GitHub Actions