Skip to content

feat: spec.secrets must be existing secrets #1961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

alex1989hu
Copy link

@alex1989hu alex1989hu commented Jun 5, 2025

CHANGE DESCRIPTION

Problem:
#1960

Cause:
This is the current logic of the code.

Solution:
Make sure that secrets specified in the manifest are preserved and not overwritten by the operator.

Closes #1960

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?
  • Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported MongoDB version?
  • Does the change support oldest and newest supported Kubernetes version?

Signed-off-by: Alex Szakaly <alex.szakaly@gmail.com>
@pull-request-size pull-request-size bot added the size/M 30-99 lines label Jun 5, 2025
@CLAassistant
Copy link

CLAassistant commented Jun 5, 2025

CLA assistant check
All committers have signed the CLA.

@gkech gkech added the community label Jun 5, 2025
Signed-off-by: Alex Szakaly <alex.szakaly@gmail.com>
@alex1989hu
Copy link
Author

Before fixing unit test and E2E failures I'd like to discuss the approach. Please see the comment here #1960 (comment)

Signed-off-by: Alex Szakaly <alex.szakaly@gmail.com>
@pull-request-size pull-request-size bot added size/L 100-499 lines and removed size/M 30-99 lines labels Jun 6, 2025
@JNKPercona
Copy link
Collaborator

Test name Status
arbiter passed
balancer passed
cross-site-sharded passed
custom-replset-name passed
custom-tls passed
custom-users-roles passed
custom-users-roles-sharded passed
data-at-rest-encryption passed
data-sharded passed
demand-backup passed
demand-backup-eks-credentials-irsa passed
demand-backup-fs passed
demand-backup-incremental passed
demand-backup-incremental-sharded passed
demand-backup-physical-parallel passed
demand-backup-physical-aws passed
demand-backup-physical-azure passed
demand-backup-physical-gcp passed
demand-backup-physical-minio passed
demand-backup-physical-sharded-parallel passed
demand-backup-physical-sharded-aws passed
demand-backup-physical-sharded-azure passed
demand-backup-physical-sharded-gcp passed
demand-backup-physical-sharded-minio passed
demand-backup-sharded passed
expose-sharded passed
finalizer passed
ignore-labels-annotations failure
init-deploy passed
ldap passed
ldap-tls passed
limits failure
liveness passed
mongod-major-upgrade passed
mongod-major-upgrade-sharded passed
monitoring-2-0 passed
monitoring-pmm3 passed
multi-cluster-service passed
multi-storage passed
non-voting-and-hidden passed
one-pod passed
operator-self-healing-chaos passed
pitr passed
pitr-physical failure
pitr-sharded passed
pitr-physical-backup-source failure
preinit-updates failure
pvc-resize passed
recover-no-primary passed
replset-overrides passed
rs-shard-migration passed
scaling passed
scheduled-backup passed
security-context passed
self-healing-chaos passed
service-per-pod passed
serviceless-external-nodes passed
smart-update passed
split-horizon passed
stable-resource-version failure
storage passed
tls-issue-cert-manager passed
upgrade passed
upgrade-consistency passed
upgrade-consistency-sharded-tls failure
upgrade-sharded passed
users failure
version-service passed
We run 68 out of 68

commit: db56ee7
image: perconalab/percona-server-mongodb-operator:PR-1961-db56ee7c

@hors
Copy link
Collaborator

hors commented Jun 21, 2025

Before fixing unit test and E2E failures I'd like to discuss the approach. Please see the comment here #1960 (comment)

Hi @alex1989hu,
Thanks for your contribution! Due to team vacations, we’re currently experiencing some delays in reviewing PRs. We’ll review your suggestion and provide feedback within a week. Appreciate your patience!

@egegunes egegunes assigned gkech and unassigned egegunes Jun 30, 2025
@egegunes
Copy link
Contributor

@gkech could you please check this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community size/L 100-499 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Defined secrets should be treated as existing secrets
6 participants