-
Notifications
You must be signed in to change notification settings - Fork 156
feat: spec.secrets must be existing secrets #1961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Alex Szakaly <alex.szakaly@gmail.com>
Signed-off-by: Alex Szakaly <alex.szakaly@gmail.com>
Before fixing unit test and E2E failures I'd like to discuss the approach. Please see the comment here #1960 (comment) |
Signed-off-by: Alex Szakaly <alex.szakaly@gmail.com>
commit: db56ee7 |
Hi @alex1989hu, |
@gkech could you please check this? |
CHANGE DESCRIPTION
Problem:
#1960
Cause:
This is the current logic of the code.
Solution:
Make sure that secrets specified in the manifest are preserved and not overwritten by the operator.
Closes #1960
CHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
compare/*-oc.yml
)?Config/Logging/Testability