Skip to content

K8SPSMDB-1344: Add size into backup status #1939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

egegunes
Copy link
Contributor

@egegunes egegunes commented May 20, 2025

K8SPSMDB-1344 Powered by Pull Request Badge

CHANGE DESCRIPTION

Problem:
Backup size is not visible in k8s object status.

Solution:
Add status.size field. Operator is using PBM's own function to pretty print the size so status.size should match the size in pbm status. I also added this as a column:

NAME      CLUSTER           STORAGE      DESTINATION                                  TYPE               SIZE       STATUS   COMPLETED   AGE
backup1   cluster1          minio        s3://operator-testing/2025-05-20T14:20:34Z   logical            47.67KB    ready    73m         73m
backup2   cluster1          minio        s3://operator-testing/2025-05-20T14:20:56Z   physical           1.29MB     ready    73m         73m
backup3   cluster1          minio        s3://operator-testing/2025-05-20T14:21:24Z   incremental-base   1.47MB     ready    72m         72m
backup4   cluster1          minio        s3://operator-testing/2025-05-20T14:21:49Z   incremental        914.50KB   ready    72m         72m

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?
  • Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported MongoDB version?
  • Does the change support oldest and newest supported Kubernetes version?

@pull-request-size pull-request-size bot added the size/M 30-99 lines label May 20, 2025
@github-actions github-actions bot added the tests label May 20, 2025
@egegunes egegunes marked this pull request as ready for review May 20, 2025 15:36
@@ -19788,7 +19796,7 @@ spec:
serviceAccountName: percona-server-mongodb-operator
containers:
- name: percona-server-mongodb-operator
image: percona/percona-server-mongodb-operator:1.20.0
image: perconalab/percona-server-mongodb-operator:main
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this change be part of this PR?

@JNKPercona
Copy link
Collaborator

Test name Status
arbiter passed
balancer passed
cross-site-sharded passed
custom-replset-name failure
custom-tls passed
custom-users-roles passed
custom-users-roles-sharded passed
data-at-rest-encryption passed
data-sharded passed
demand-backup passed
demand-backup-eks-credentials-irsa passed
demand-backup-fs passed
demand-backup-incremental passed
demand-backup-incremental-sharded failure
demand-backup-physical passed
demand-backup-physical-sharded passed
demand-backup-sharded failure
expose-sharded passed
finalizer passed
ignore-labels-annotations passed
init-deploy passed
ldap passed
ldap-tls passed
limits passed
liveness passed
mongod-major-upgrade passed
mongod-major-upgrade-sharded passed
monitoring-2-0 passed
monitoring-pmm3 passed
multi-cluster-service passed
multi-storage passed
non-voting passed
one-pod passed
operator-self-healing-chaos passed
pitr passed
pitr-physical passed
pitr-sharded passed
pitr-physical-backup-source passed
preinit-updates passed
pvc-resize passed
recover-no-primary passed
replset-overrides passed
rs-shard-migration passed
scaling passed
scheduled-backup passed
security-context passed
self-healing-chaos passed
service-per-pod passed
serviceless-external-nodes passed
smart-update passed
split-horizon passed
stable-resource-version passed
storage passed
tls-issue-cert-manager passed
upgrade passed
upgrade-consistency passed
upgrade-consistency-sharded-tls passed
upgrade-sharded passed
users passed
version-service passed
We run 60 out of 60

commit: c5a06cd
image: perconalab/percona-server-mongodb-operator:PR-1939-c5a06cd5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M 30-99 lines tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants