K8SPSMDB-297 support persistent logs #1936
Open
+1,213
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkech
force-pushed
the
K8SPSMDB-297
branch
6 times, most recently
from
c3e53e6 to
63f5e16
Compare
pull-request-size
bot
added
size/XXL
gkech
force-pushed
the
K8SPSMDB-297
branch
5 times, most recently
from
93f17f2 to
18f9557
Compare
pull-request-size
bot
added
size/XL
gkech
force-pushed
the
K8SPSMDB-297
branch
3 times, most recently
from
535245f to
d72b63f
Compare
pull-request-size
bot
added
size/XXL
gkech
requested review from
jvpasinatto,
eleo007,
hors,
egegunes and
pooknull
as code owners
gkech
force-pushed
the
K8SPSMDB-297
branch
3 times, most recently
from
11516e8 to
1ade2b4
Compare
egegunes
requested changes
May 21, 2025
There was a problem hiding this comment.
do we need this? if yes, we need to fix the typo in the file name
| @@ -743,3 +743,10 @@ spec: | |||
| # storageName: s3-us-west | |||
| # compressionType: gzip | |||
| # compressionLevel: 6 | |||
| logcollector: | |||
| enabled: true | |||
| image: perconalab/percona-xtradb-cluster-operator:main-logcollector | |||
There was a problem hiding this comment.
we need to fix this image, is this temporary?
There was a problem hiding this comment.
Until the new images for Fluentbit are ready, I think we should keep this as is. We can change it with a new PR once these new images are ready.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| fluentbit_opt+='-c /opt/percona/logcollector/fluentbit/fluentbit.conf' | ||
| fi | ||
|
|
||
| exec "$@" $fluentbit_opt |
There was a problem hiding this comment.
[shellcheck (suggestion)] reported by reviewdog 🐶
Suggested change
| exec "$@" $fluentbit_opt | |
| exec "$@" "$fluentbit_opt" |
| @@ -480,6 +480,11 @@ if [[ $originalArgOne == mongo* ]]; then | |||
| _mongod_hack_rename_arg_save_val --sslDisabledProtocols --tlsDisabledProtocols "${mongodHackedArgs[@]}" | |||
| fi | |||
|
|
|||
| if [[ $originalArgOne == "mongod" && "${LOGCOLLECTOR_ENABLED:-}" == "true" ]]; then | |||
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
| if [[ $originalArgOne == "mongod" && "${LOGCOLLECTOR_ENABLED:-}" == "true" ]]; then | |
| if [[ $originalArgOne == "mongod" && ${LOGCOLLECTOR_ENABLED:-} == "true" ]]; then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
Logs are available only for the lifecycle of the particular pods. With this PR we are introducing the support for persistent logs in PVC (separate from the PVC used for actual mongo data), focusing for now only on the
mongodlogs.Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Image:
perconalab/percona-server-mongodb-operator:K8SPSMDB-297-22The solution utilises FluentBit to manage the log pipeline, appending the appropriate metadata and storing the logs in a single file in a log-specific PVC for each pod. The logs can also be visible on stdout.
As part of this pr, we moved the required files for fluentbit from here: https://github.com/percona/percona-docker/tree/main/fluentbit to this repo and we mount them to the
logsandlogrotationcontainers.In terms of documentation, the functionality is similar to this: https://docs.percona.com/percona-operator-for-mysql/pxc/debug-logs.html
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
compare/*-oc.yml)?Config/Logging/Testability