-
Notifications
You must be signed in to change notification settings - Fork 151
K8SPSMDB-1308: Improve physical restore logs #1915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
egegunes
wants to merge
15
commits into
main
Choose a base branch
from
K8SPSMDB-1308
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+63
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+34
to
+35
echo "Still in progress at $(date)" | ||
sleep 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[shfmt] reported by reviewdog 🐶
Suggested change
echo "Still in progress at $(date)" | |
sleep 10 | |
echo "Still in progress at $(date)" | |
sleep 10 |
gkech
previously approved these changes
May 20, 2025
hors
previously approved these changes
May 20, 2025
* K8SPSMDB-1265: Update versions for 1.20.0 release * Update test dependencies versions * Update cr images
…estore (#1911) Use kubectl wait instead of regular loop in `wait_restore()` Add retry for `demand-backup-sharded` test backup presence in minio storage Delete backups during test cleanup before removing finalizers from objects.
* K8SPSMDB-1265: Print operator version details
* K8SPSMDB-1268 pmm3 support * fix imports * assert the env var lengths * add server host * cover more inits in test * add custom params * improve test * remove spammy logs * e2e tests * fix mounts for pmm3 container * update secret with new token comment * wrapup e2e test * drop unused env vars * ensure that pmm3 test is fully functional * bonus: improve the custom name e2e verification * add small assertion to ensure that disabled pmm and nil secret return no container * make custom cluster name configurable in cr for the e2e test * fix linter * cr: package rename to config * add some more test cases
* K8SPSMDB-1216 update to db.hello * update rs-shard-migration test --------- Co-authored-by: Viacheslav Sarzhan <slava.sarzhan@percona.com>
commit: 2d82912 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
Physical restore logs are lost after restore is finished.
Solution:
Logs can be found in
/data/db/pbm-restore-logs
after restore.Warning
PBM will delete
/data/db/pbm-restore-logs
if you run a new physical restore.You can only see logs of the latest restore.
CHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
compare/*-oc.yml
)?Config/Logging/Testability