K8SPSMDB-1154: disable encryption by default for inMemory #1912
+34
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pooknull
requested review from
hors,
egegunes,
nmarukovich and
gkech
as code owners
gkech
reviewed
May 19, 2025
pkg/apis/psmdb/v1/psmdb_defaults.go
Outdated
Comment on lines
738
to
745
| encryptionEnabled, err := rs.Configuration.IsEncryptionEnabled() | ||
| if err != nil { | ||
| return errors.Wrap(err, "failed to parse replset configuration") | ||
| } | ||
| if encryptionEnabled != nil && *encryptionEnabled { | ||
| return errors.New("inMemory storage engine doesn't support encryption") | ||
| } | ||
| } |
There was a problem hiding this comment.
Since we already have the function func isEncryptionEnabled(cr *api.PerconaServerMongoDB, replset *api.ReplsetSpec) (bool, error) { . I think we can utilize it for the most part of this logic by returning a verified not nil boolean.
There was a problem hiding this comment.
Just to note, I think that we can move this function in psmdb_defaults and then utilize it elsewhere in the codebase.
gkech
reviewed
May 19, 2025
pkg/psmdb/statefulset.go
Outdated
| @@ -584,7 +584,11 @@ func isEncryptionEnabled(cr *api.PerconaServerMongoDB, replset *api.ReplsetSpec) | |||
| if err != nil { | |||
| return false, errors.Wrap(err, "failed to parse replset configuration") | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Since the cr is not used by this function at all, maybe we can remove it from the function signature.
egegunes
approved these changes
May 21, 2025
commit: ab1be45 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/K8SPSMDB-1154
DESCRIPTION
Problem:
It's not possible to deploy a cluster with the
--enableEncryptionflag when theinMemorystorage engine is used.Solution:
Don't set the
--enableEncryptionflag when theinMemorystorage engine is used.CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
compare/*-oc.yml)?Config/Logging/Testability