K8SPG-645 turn on sidecar containers for pgbouncer

[nmarukovich]

CHANGE DESCRIPTION

Problem:
Sidecar containers for pgbouncer don't work by default

Cause:
We need to turn on PGBouncerSidecars variable

Solution:
Turn on it.

CHECKLIST

Jira

• Is the Jira ticket created and referenced properly?
• Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
• Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

• Is an E2E test/test case added for the new feature/change?
• Are unit tests added where appropriate?

Config/Logging/Testability

• Are all needed new/changed options added to default YAML files?
• Are all needed new/changed options added to the Helm Chart?
• Did we add proper logging messages for operator actions?
• Did we ensure compatibility with the previous version or cluster upgrade process?
• Does the change support oldest and newest supported PG version?
• Does the change support oldest and newest supported Kubernetes version?

[nmarukovich]

@egegunes @inelpandzic @pooknull I have a question here.
Is there any reason why we didn't turn on it by default before?
If yes, do we want to move it to cr option?
For instances it is turned on by default.
Crunchy suggested use env var

PGO_FEATURE_GATES="PGBouncerSidecars=true"

[hors]

@egegunes @inelpandzic @pooknull I have a question here. Is there any reason why we didn't turn on it by default before? If yes, do we want to move it to cr option? For instances it is turned on by default. Crunchy suggested use env var

PGO_FEATURE_GATES="PGBouncerSidecars=true"

@nmarukovich We need to have it by default.

[nmarukovich]

@egegunes @inelpandzic @pooknull I have a question here. Is there any reason why we didn't turn on it by default before? If yes, do we want to move it to cr option? For instances it is turned on by default. Crunchy suggested use env var
PGO_FEATURE_GATES="PGBouncerSidecars=true"

@nmarukovich We need to have it by default.

So please approve in this case (=

[JNKPercona]

Test name	Status
custom-extensions	passed
custom-tls	passed
demand-backup	passed
finalizers	passed
init-deploy	passed
monitoring	passed
one-pod	passed
operator-self-healing	passed
pitr	passed
scaling	passed
scheduled-backup	passed
self-healing	passed
sidecars	passed
start-from-backup	passed
tablespaces	passed
telemetry-transfer	passed
upgrade-consistency	passed
upgrade-minor	passed
users	passed
We run 19 out of 19

commit: 0946780
image: perconalab/percona-postgresql-operator:PR-968-0946780d4