K8SPG-553: Allow setting root CA manually #876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hors
requested changes
Aug 27, 2024
e2e-tests/functions
Outdated
| kubectl create namespace cert-manager || : | ||
| kubectl label namespace cert-manager certmanager.k8s.io/disable-validation=true || : | ||
| kubectl apply -f "https://github.com/jetstack/cert-manager/releases/download/v${CERT_MANAGER_VER}/cert-manager.yaml" --validate=false || : 2>/dev/null | ||
| if [ "$OPENSHIFT" == "4.10" ]; then |
There was a problem hiding this comment.
I think we do not support OPENSHIFT 4.10 long time ago
pooknull
requested review from
tplavcic,
nmarukovich,
ptankov,
jvpasinatto,
eleo007,
egegunes and
inelpandzic
as code owners
egegunes
approved these changes
Aug 29, 2024
egegunes
requested changes
Aug 29, 2024
inelpandzic
previously approved these changes
Sep 4, 2024
| // The secret containing the root CA certificate and key for | ||
| // secure connections to the PostgreSQL server. It will need to contain the | ||
| // CA TLS certificate and CA TLS key with the data keys set to | ||
| // root.crt and root.key, respectively. |
There was a problem hiding this comment.
We shouldn't forget to have this in our docs as well I think. @fiowro
egegunes
previously approved these changes
Sep 4, 2024
inelpandzic
approved these changes
Sep 5, 2024
nmarukovich
reviewed
Sep 5, 2024
| // RootCertSecret is the default root certificate secret name | ||
| RootCertSecret = "pgo-root-cacert" /* #nosec */ | ||
| // RootCertSecret = "pgo-root-cacert" /* #nosec */ |
There was a problem hiding this comment.
Why we commented it. Should we delete it?
There was a problem hiding this comment.
We comment unused crunchy code to simplify the merge process, as seen here:
percona-postgresql-operator/internal/controller/postgrescluster/pgbouncer.go
Lines 234 to 238 in 8910766
nmarukovich
approved these changes
Sep 5, 2024
egegunes
approved these changes
Sep 6, 2024
commit: 4db807a |
hors
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/K8SPG-553
https://perconadev.atlassian.net/browse/K8SPG-555
DESCRIPTION
K8SPG-555: The operator will create a different ca secret per cluster with the name<cluster-name>-cluster-ca-certinstead ofpgo-root-cacertK8SPG-553: Add a.spec.secrets.customRootCATLSSecretfield, which is used to specify data about the CA secret to be used by a cluster.CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
Config/Logging/Testability