K8SPG-570 update custom secret with labels when they are missing, update missing secret data with autogeneration #1218
+228
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
By default, the operator will overwrite the user secret if it is custom-created and create a new one with fresh credentials for the user. The only way to avoid this is to provide all the data fields of the secret, or, as pointed out here: https://perconadev.atlassian.net/browse/K8SPG-570?focusedCommentId=426612, provide some specific labels to the secret so that the operator can track it and utilize it to fill in the missing secret data fields.
Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Testing
cr:
Demo secret with only password defined created before applying the
cat
user cr:Secret after applying the CR for the user:
Notice that all the related properties were automatically added to the secret, keeping the original password that was specified by the secret that was created manually.
Note that the aforementioned scenario is also added on the e2e test.
CHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
Config/Logging/Testability