K8SPG-703: add internal.percona.com/keep-job finalizer for backups
#1134
+63
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pooknull
requested review from
hors,
egegunes,
nmarukovich and
gkech
as code owners
gkech
reviewed
Apr 23, 2025
| @@ -265,6 +274,21 @@ func (r *PGBackupReconciler) Reconcile(ctx context.Context, request reconcile.Re | |||
|
|
|||
| return reconcile.Result{}, nil | |||
| case v2.BackupSucceeded: | |||
| job, err := findBackupJob(ctx, r.Client, pgBackup) | |||
| if err == nil && len(job.Finalizers) > 0 { | |||
There was a problem hiding this comment.
Why don't we assert that the specific finalizer we created for this PR, If it is set, and instead we are checking if the job finalizers are not empty? If we decide at some point to have more finalizers for some reason, what would happen to this logic?
|
@pooknull ping |
gkech
previously approved these changes
May 13, 2025
egegunes
previously approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/K8SPG-703
DESCRIPTION
Problem:
Backup jobs may be deleted before they are finished (e.g. via
ttlSecondsAfterFinished), causingpg-backupto be stuck in theRunningstate.Solution:
Add
internal.percona.com/keep-jobfinalizer to backup jobs to prevent them from being deleted while they are running. The finalizer should be automatically removed when the backup finishes or fails.CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
Config/Logging/Testability