-
Notifications
You must be signed in to change notification settings - Fork 64
K8SPG-613: replace initImage with initContainer #1117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
we have some assertion issues on the |
we need to also check the unit tests, |
pkg/apis/postgres-operator.crunchydata.com/v1beta1/postgrescluster_types.go
Show resolved
Hide resolved
@@ -11,4 +11,5 @@ commands: | |||
get_cr \ | |||
| yq eval ' | |||
.spec.crVersion="2.5.0"' - \ | |||
| yq eval ".spec.backups.pgbackrest.image=\"${IMAGE_BASE}:main-ppg$PG_VER-pgbackrest\"" - \ | |||
| kubectl -n "${NAMESPACE}" apply -f - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hors should we use updated image name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nmarukovich only from PGO 2.7.0
commit: f62c485 |
@pooknull LGTM but please create helm chart PR |
https://perconadev.atlassian.net/browse/K8SPG-613
DESCRIPTION
This PR replaces
.spec.initImage
and.spec.backups.pgbackrest.initImage
with.spec.initContainer
and.spec.backups.pgbackrest.initContainer
.These fields have the following spec:
CHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
Config/Logging/Testability