Skip to content

Feature request: #1248 Implement a discrete straight-line constraint for the polyline - Fixed bug #1890 #1910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Feature request: #1248 Implement a discrete straight-line constraint for the polyline - Fixed bug #1890 #1910

wants to merge 2 commits into from

Conversation

@Goodfite4
Copy link

@Goodfite4 Goodfite4 commented Apr 4, 2025 •
edited by chchwy
Loading

Fix #1890
Implement #1248

@github-project-automation github-project-automation bot moved this to Needs Review in Pull Request Priority Apr 4, 2025
@Goodfite4 Goodfite4 changed the title Added issue #1248 Implement a discrete straight-line constraint for the polyline- Fixed bug #1890 Feature request: #1248 Implement a discrete straight-line constraint for the polyline - Fixed bug #1890 Apr 4, 2025
@Goodfite4
Copy link
Author

Goodfite4 commented Apr 4, 2025

If I missed anything or made a mistake, let me know so I can fix it quickly. Thanks.

@Goodfite4 Goodfite4 mentioned this pull request Apr 4, 2025
Open
@chchwy
Copy link
Member

chchwy commented Jun 3, 2025

Hey @Goodfite4, thank you for your contribution. Would you be able to briefly explain this PR? I saw you add two options "snapAngleDegrees" and "snapAngleBox", what's the idea behind them?

khoidauminh and others added 2 commits June 4, 2025 22:13
@khoidauminh @chchwy
Enable antialiasing option for move tool (pencil2d#1905)
716ebbe
@Goodfite4 @chchwy
- Added a Snap To Angle Feature on the Polyline Tool
d2cabce 
- Resolved bug - Graphical issue when equipping polytool and zooming pencil2d#1890
- Fixed All build Errors and typos.
@chchwy chchwy self-assigned this Jun 5, 2025
@Goodfite4
Copy link
Author

Goodfite4 commented Jun 5, 2025

Hey @Goodfite4, thank you for your contribution. Would you be able to briefly explain this PR? I saw you add two options "snapAngleDegrees" and "snapAngleBox", what's the idea behind them?

The SnapAngleDegree is for the user to specify what angle they want the polyline to snap to. So if you input 45, the polyline will snap to the closest divisible by 45 angle(0 , 45, 90, 135, etc). The Snap Angle Box is for users to check on and off if they actually want the polyline tool to snap to a certain angle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@chchwy chchwy

Labels

None yet

Projects

Pull Request Priority
Status: Needs Review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🐛 [BUG] Graphical issue when equipping polytool and zooming

3 participants

@Goodfite4 @chchwy @khoidauminh