marshal: don't escape quotes unnecessarily #991
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only 3 consecutive quotation marks need to be quoted. We choose to quote all quotation marks in a sequence if there are 3 or more consecutive present.
Fixes #990
Strictly speaking, this would break backwards compatibility if anyone was using a textual comparison of the output of Marshal (as opposed to the semantic content). Could hide it behind an additional tag/option if that seems like a concern.
I've not used benchstat before, but I think there's a slight performance penalty, but worth it for me :)
Results of
./ci.sh benchmark -d v2
: