Replace stretchr/testify with an internal test suite
#981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As recommended, an `internal/assert` package was added with a reduced set of assertions. All tests were then refactored to use the internal assertions. When more complex assertions were used, they have been rewritten using logic and the simplified assertions. Fancy formatting for failures was omitted. The `internal/assert/assertions.diff` function could be overwritten for better formatting. That is where diff libraries are used in other test suites. Refs: pelletier#872
|
Thank you for making this change! |
pelletier
added
testing
alexandear
reviewed
Apr 7, 2025
| } | ||
| t.Helper() | ||
| msg := formatMsgAndArgs("Expected zero value but got:", msgAndArgs...) | ||
| t.Fatalf("%s\n%s", msg, fmt.Sprintf("%v", value)) |
There was a problem hiding this comment.
Why not?
t.Fatalf("%s\n%v", msg, value)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As recommended, an
internal/assertpackage was added with a reduced set of assertions. All tests were then refactored to use the internal assertions. When more complex assertions were used, they have been rewritten using logic and the simplified assertions.Fancy formatting for failures was omitted. The
internal/assert/assertions.difffunction could be overwritten for better formatting. That is where diff libraries are used in other test suites.Refs: #872