Skip to content

Fixing Issue 152, for the At Symbol #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 14, 2025
Merged

Fixing Issue 152, for the At Symbol #360

merged 6 commits into from
May 14, 2025

Conversation

esw0624
Copy link
Contributor

@esw0624 esw0624 commented May 13, 2025

Fixes Issue #152

pearcej
pearcej requested changes May 13, 2025
View reviewed changes
Copy link
Owner

@pearcej pearcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect. You needed to revert and change ONLY the paragraphs tags to subsubsection tags. You now have subsubsection tags nested inside of subsubsection tags, which is not correct.

pearcej
pearcej requested changes May 14, 2025
View reviewed changes
Copy link
Owner

@pearcej pearcej left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not quite correct. There are subsubsections that are not in a subsection.

image

Can you please correct?

Also please tag your reviewer.

@esw0624 esw0624 marked this pull request as draft May 14, 2025 17:11
@esw0624 esw0624 marked this pull request as ready for review May 14, 2025 17:19
@esw0624
Copy link
Contributor Author

esw0624 commented May 14, 2025

Reviewed by Tristan and Logan

pearcej
pearcej approved these changes May 14, 2025
View reviewed changes
Copy link
Owner

@pearcej pearcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

@pearcej pearcej merged commit c015d0a into pearcej:main May 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pearcej pearcej pearcej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esw0624 @pearcej