Skip to content

Fix tibble dependency issue in read_sf() #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2025

Conversation

pdil
Copy link
Owner

@pdil pdil commented Jun 13, 2025

Changes

  • Set as_tibble = FALSE in create_us_map(), us_map(), and centroid_labels()

Notes

  • This change is due to ggplot2 no longer importing tibble by default (now a Suggests).
  • For the purposes of this package, reading the simple features data as a data frame is suitable.
  • Any package consumers that require tibbles can easily convert them using tibble::as_tibble().
  • Originally reported in usmap: tibble dependency usmap#117

resolves #53

@pdil pdil self-assigned this Jun 13, 2025
@pdil pdil added the bug A bug or issue that should be resolved label Jun 13, 2025
@pdil pdil marked this pull request as ready for review June 13, 2025 19:48
@pdil pdil merged commit 2b0af7e into master Jun 14, 2025
8 checks passed
@pdil pdil deleted the bugfix/fix-tibble-dependency branch June 14, 2025 01:01
@pdil pdil mentioned this pull request Jun 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug or issue that should be resolved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix tibble dependency issue
1 participant