Decoder improvements #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an error type and a function to check if a decoder still needs data for a complete frame. Signed-off-by: Pieter De Gendt <pieter.degendt@basalte.be>
With the introduction of NeedsMoreData we should verify decoder states in the current tests. Signed-off-by: Pieter De Gendt <pieter.degendt@basalte.be>
A simple test case for some frames that are missing data. Signed-off-by: Pieter De Gendt <pieter.degendt@basalte.be>
Add some simple tests for encountering unexpected delimiters. Signed-off-by: Pieter De Gendt <pieter.degendt@basalte.be>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
==========================================
+ Coverage 93.75% 97.05% +3.30%
==========================================
Files 1 1
Lines 96 102 +6
==========================================
+ Hits 90 99 +9
+ Misses 4 2 -2
+ Partials 2 1 -1
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NeedsMoreDatamethod to the decoder to check for incomplete frames.