Make Ogg FormatReader work for partial MediaSourceStreams #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1c3t3a
force-pushed
the
remember-ogg-page-position
branch
from
d471298 to
14b22d7
Compare
At the moment, the Ogg FormatReader assumes a complete MediaSourceStream, which allows to seek to the last page. This assumption breaks for partial decodes (MediaSourceStream::Read may return UnexpectedEof multiple times and then continues to fetch data that is available on the next call). This patch allows decoding in chunks, similar to libogg behavior. Concretely this means: 1. When reading from a MediaSourceStream, we sync back to the last healthy position when experiencing an UnexpectedEof. 2. If the last page was not present when initializing the format reader, we compute the end_delay when reaching the last page. Co-authored-by: Jakob Koschel <jakobkoschel@google.com>
1c3t3a
force-pushed
the
remember-ogg-page-position
branch
from
14b22d7 to
09b0567
Compare
1c3t3a
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, the Ogg FormatReader assumes a complete MediaSourceStream, which allows to seek to the last page. This assumption breaks for partial decodes (MediaSourceStream::Read may return UnexpectedEof multiple times and then continues to fetch data that is available on the next call). This patch allows decoding in chunks, similar to libogg behavior.
Concretely this means:
position when experiencing an UnexpectedEof.
we compute the end_delay when reaching the last page.
cc: @jakos-sec