Skip to content

Conversation

hamzanasir
Copy link
Contributor

@hamzanasir hamzanasir commented Aug 13, 2025

This PR aims to add an example to the repo demonstrating the recommended approach for merchant's to run custom async validation with the v6 SDK. It also has README.md file explaining what User Transient Activation is and why it's important to consider when integrating with the SDK

@hamzanasir hamzanasir requested a review from a team as a code owner August 13, 2025 19:41
Copy link
Contributor

@gregjopa gregjopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this out locally and it works great. Nice work @hamzanasir! 💯
Screenshot 2025-08-13 at 2 58 05 PM

Copy link
Contributor

@nbierdeman nbierdeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome example, @hamzanasir! 🤘

</div>
</div>

<div class="buttons-container">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Total nitpick here. 😂

Suggested change
<div class="buttons-container">
<div class="button-container">

Copy link
Contributor Author

@hamzanasir hamzanasir Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No nitpicking this totally makes sense! I think that the goal of this container is that you can possibly add more buttons here too. And I believe we follow a similar pattern with the other examples as well:

Do you think it's cool if we keep it this way for consistency? Totally down to change it later in a follow up PR as well if you think we should change it 🙂

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm down for keeping it plural, since it's implying that more buttons can/will be added.

@hamzanasir hamzanasir merged commit b03b935 into main Aug 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants