-
Notifications
You must be signed in to change notification settings - Fork 11
feat: Add Google Pay Example #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@hamzanasir can you run prettier locally? Looks like CI is failing because of code formatting. |
@gregjopa Thanks for calling that out! I think my editor wasn't auto-formatting because we don't have a |
Thanks @hamzanasir. I like adding a default .prettierrc file to root of the project to tell editors to use the default prettier settings when formatting on save. Great improvement. |
client/components/googlePayPayments/oneTimePayment/html/src/app.js
Outdated
Show resolved
Hide resolved
googlePaySession, | ||
) { | ||
try { | ||
const orderPayload = getPayPalOrder(purchaseAmount); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: can we name this getPayPalOrderPayload
to help clarify that its not doing an ORDER GET operation with the API?
const orderPayload = getPayPalOrder(purchaseAmount); | |
const orderPayload = getPayPalOrderPayload(purchaseAmount); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another great suggestion. I think that's an important clarification to make 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @hamzanasir! I left some minor comments about function names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR aims to add an example for creating and processing a one-time google pay transaction with the v6 PayPal SDK and the google pay SDK.