chore: add github actions for linting and formatting checks #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bywood
approved these changes
May 7, 2025
client/savePayment/html/package.json
Outdated
| "preview": "vite preview", | ||
| "start": "vite", | ||
| "format": "npx prettier . --write" | ||
| "format": "npx prettier . --write", |
There was a problem hiding this comment.
Think you can drop the npx here.
There was a problem hiding this comment.
Great catch. Just removed npx from here.
kand
reviewed
May 7, 2025
| find . -name package.json -maxdepth 10 -type f -not -path "*/node_modules/*" | while read -r file; do | ||
| directory=$(dirname "$file") | ||
| echo "::group:: $directory" | ||
| cd "$directory" && npm run lint && cd - |
There was a problem hiding this comment.
While you're at it, would it be helpful to have these as pre-commit hooks as well?
There was a problem hiding this comment.
I like the idea of adding them as precommit hooks too. Let's do that in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds GitHub Actions for running prettier formatting checks and eslint checks. Here's a screenshot of the output:
One goal with this repo is to support other languages like java and php. So I've avoided adding a root package.json and using a monorepo for that reason.