perf(graphql): skip count query for join field using simple pagination #12223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes GraphQL join field queries by skipping the unnecessary count query and using a simple limit-plus-slice approach for pagination.
- Updated the find query to request one extra document (limit + 1) to detect if more results exist
- Disabled built-in pagination and implemented a slicing mechanism to handle the extra document
Comments suppressed due to low confidence (1)
packages/graphql/src/schema/fieldToSchemaMap.ts:411
- [nitpick] Consider renaming 'shouldSlice' to 'hasExtraDoc' to more clearly indicate that it flags the presence of an extra document used to detect the next page.
let shouldSlice = false
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
🚀 This is included in version v3.36.0 |
kendelljoseph
pushed a commit
that referenced
this pull request
May 15, 2025
#12223) GraphQL requests with join fields result in a lot of extra count rows queries that aren't necessary. This turns off pagination and uses limit+1 and slice instead.
kendelljoseph
pushed a commit
that referenced
this pull request
May 19, 2025
#12223) GraphQL requests with join fields result in a lot of extra count rows queries that aren't necessary. This turns off pagination and uses limit+1 and slice instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GraphQL requests with join fields result in a lot of extra count rows queries that aren't necessary. This turns off pagination and uses a simple limit and slice instead.