fix(graphql): nextPage and prevPage are non nullable even though they can be null sometimes
#12201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…they can be `null` in some cases
|
@r1tsuu @DanRibbens Hi, could we include this change for next release? |
DanRibbens
approved these changes
May 5, 2025
|
🚀 This is included in version v3.37.0 |
kendelljoseph
pushed a commit
that referenced
this pull request
May 15, 2025
…they can be `null` sometimes (#12201) This PR introduced #11952 improvement for graphql schema with making fields of the `Paginated<T>` interface non-nullable. However, there are a few special ones - `nextPage` and `prevPage`. They can be `null` when: The result returned 0 docs. The result returned `x` docs, but in the DB we don't have `x+1` doc. Thus, `nextPage` will be `null`. The result will have `nextPage: null`. Finally, when we query 1st page, `prevPage` is `null` as well. <img width="873" alt="image" src="https://github.com/user-attachments/assets/04d04b13-ac26-4fc1-b421-b5f86efc9b65" />
kendelljoseph
pushed a commit
that referenced
this pull request
May 19, 2025
…they can be `null` sometimes (#12201) This PR introduced #11952 improvement for graphql schema with making fields of the `Paginated<T>` interface non-nullable. However, there are a few special ones - `nextPage` and `prevPage`. They can be `null` when: The result returned 0 docs. The result returned `x` docs, but in the DB we don't have `x+1` doc. Thus, `nextPage` will be `null`. The result will have `nextPage: null`. Finally, when we query 1st page, `prevPage` is `null` as well. <img width="873" alt="image" src="https://github.com/user-attachments/assets/04d04b13-ac26-4fc1-b421-b5f86efc9b65" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduced #11952 improvement for graphql schema with making fields of the
Paginated<T>interface non-nullable.However, there are a few special ones -
nextPageandprevPage. They can benullwhen:The result returned 0 docs.
The result returned
xdocs, but in the DB we don't havex+1doc. Thus,nextPagewill benull. The result will havenextPage: null. Finally, when we query 1st page,prevPageisnullas well.