Skip to content

RightToLeft #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

RightToLeft #35

wants to merge 2 commits into from

Conversation

Shaboo
Copy link

@Shaboo Shaboo commented Sep 25, 2019

Submission description

I wanted to test RightToLeft, and scrollview

rtl

What went well

I was surprised how RightToLeft is supported, When I set FlowDirection="RightToLeft", The first page was as expected,
Excellent job Xamarin team, Go Ahead

What didn't go well

with VS2017, the app crashes immediatly, I couldn't fix it.
with VS2019, when i write as following, i get exception with "cast not valid" message:

<CarouselView FlowDirection="RightToLeft">
    <CarouselView.ItemTemplate>
        <DataTemplate>
            <ViewCell>
                //My template
            </ViewCell>
        </DataTemplate>
    </CarouselView.ItemTemplate>
</CarouselView>

but no crashed when i write as following:

<CarouselView FlowDirection="RightToLeft">
   <CarouselView.ItemTemplate>
       <DataTemplate>
           //My template
       </DataTemplate>
   </CarouselView.ItemTemplate>
</CarouselView>

idk if i am doing it wrong

Missing or desired things

Nothing not mentioned by other PRs

Anything else

Very good job, Go Ahead Xamarin

Take out a survey for some goodies

Please visit this link to take a survey. If you provide your contact information, we'll send you some swag!

Mohammad Shaban and others added 2 commits September 25, 2019 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant