Add object.replace method #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreibondarev
requested changes
Jul 7, 2024
There was a problem hiding this comment.
@cameronmccord2 This is great! I'm okay with the breaking change, I'll issue it in the 0.9.0 version.
A few remaining items:
- Could you please fix the CI build?
standardrb --fixto fix the linter errors. - Document the breaking change in the CHANGELOG.md
- Document the new
objects.replace()method in the README.md
Thank you! And I'll cut a new release right away.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the object.update method to use PATCH which only performs a partial update
Add object.replace method which uses PUT which performs a complete object replacement
The issue is this is considered a breaking change since object.update previously did a replace but now just does an update. I'm unsure how the maintainer would like to handle this.