Skip to content

v2 endpoint #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 23, 2024
Merged

v2 endpoint #23

merged 5 commits into from
Nov 23, 2024

Conversation

ScotterC
Copy link
Contributor

@ScotterC ScotterC commented Nov 5, 2024

Here's the changelog on Cohere's side:

model is a required field for Embed, Rerank, Classify, and Chat.
embedding_types is a required field for Embed.

For Chat there are a bunch of changes in message/response structure

@ScotterC ScotterC closed this Nov 5, 2024
@andreibondarev
Copy link
Collaborator

@ScotterC I didn't realize there's a v2 endpoint! Why'd you close it?

@ScotterC
Copy link
Contributor Author

@andreibondarev ha, cause I only looked into rerank endpoint and I had no idea how it might impact others. this PR was meant for my own fork to just test. Good news is the swap works just fine for rerank

@ScotterC ScotterC reopened this Nov 21, 2024
@ScotterC
Copy link
Contributor Author

ScotterC commented Nov 21, 2024

Re opening since I'm moving forward with using this branch of mine and tests pass locally. Will add to it if other aspects come up. I have not directly tried endpoints other than rerank though

@andreibondarev
Copy link
Collaborator

@ScotterC I have a branch that I'm working on locally. I assume it makes sense to keep both the v1 and v2 endpoints side by side, what do you think?

@andreibondarev andreibondarev self-assigned this Nov 23, 2024
@andreibondarev andreibondarev merged commit 2a377a0 into patterns-ai-core:main Nov 23, 2024
4 checks passed
@ScotterC
Copy link
Contributor Author

Sounds good to me. A major version bump works as well. Thanks for all the updates!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants