Skip to content

fix missing args for components in hbs #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 27, 2025
Merged

fix missing args for components in hbs #286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e5e171
fix glint when manually configured
patricklx Jun 20, 2025
d1f4ef9
fix missing completions for component args in hbs
patricklx Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/main/kotlin/com/emberjs/glint/GlintLspSupportProvider.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,6 @@ class GlintLspServerDescriptor(private val myProject: Project) : LspServerDescri

fun getGlintVersion(): String? {
val workingDir = lastDir!!
val workDirectory = VfsUtilCore.virtualToIoFile(workingDir)
var path = workingDir.findFileByRelativePath("node_modules/@glint/core/package.json") ?: return null
return PackageJsonData.getOrCreate(path).version?.rawVersion
}
Expand All @@ -152,7 +151,7 @@ class GlintLspServerDescriptor(private val myProject: Project) : LspServerDescri
val pkg = config.getPackage()
val pkgPath = pkg.`package`.constantPackage?.systemIndependentPath
if (pkgPath != null && File(pkgPath).exists()) {
path = File(pkgPath).parentFile.parentFile.path
path = File(pkgPath).parentFile.parentFile.parentFile.path
}
path = path.replace("\\", "/")
this.isWsl = false
Expand Down
3 changes: 3 additions & 0 deletions src/main/kotlin/com/emberjs/hbs/TagReferencesProvider.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,9 @@ fun toAttributeReference(target: XmlAttribute): PsiReference? {
if (name.length == 1) {
return null
}
if (!name.contains("|")) {
return null
}
var range = TextRange(0, name.length)
if (name.startsWith("|")) {
range = TextRange(1, range.endOffset)
Expand Down
Loading