Skip to content

Add PartiqlSharedCatalog for Send+Sync catalog usage. #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jpschorr
Copy link
Contributor

@jpschorr jpschorr commented Jun 30, 2025

  • Splits the Catalog interface into a MutableCatalog and a ReadOnlyCatalog.
  • Adds SharedCatalog: ReadOnlyCatalog + Send + Sync
  • Adds PartiqlSharedCatalog which impls SharedCatalog

TODO:

  • Add tests for shared usage

Addresses #579


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

github-actions bot commented Jun 30, 2025

Conformance comparison report

Base (2ae6c4e) ca9a88c +/-
% Passing 87.89% 87.89% 0.00%
✅ Passing 5863 5863 0
❌ Failing 808 808 0
🔶 Ignored 0 0 0
Total Tests 6671 6671 0

Number passing in both: 5863

Number failing in both: 808

Number passing in Base (2ae6c4e) but now fail: 0

Number failing in Base (2ae6c4e) but now pass: 0

Copy link

codecov bot commented Jun 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.13%. Comparing base (2ae6c4e) to head (ed3a181).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #583   +/-   ##
=======================================
  Coverage   81.13%   81.13%           
=======================================
  Files         110      110           
  Lines       21792    21796    +4     
  Branches    21792    21796    +4     
=======================================
+ Hits        17681    17685    +4     
  Misses       3593     3593           
  Partials      518      518           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jpschorr jpschorr marked this pull request as ready for review June 30, 2025 23:57
@jpschorr jpschorr requested review from am357 and alancai98 June 30, 2025 23:57
@jpschorr jpschorr force-pushed the feat-add-shared-catalog branch 2 times, most recently from 57b5f72 to 110efac Compare July 2, 2025 19:49
@jpschorr jpschorr force-pushed the feat-add-shared-catalog branch from 110efac to ed3a181 Compare July 8, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants