Add GPML logical plan and plan -> evaluator. #549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (73.20%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #549 +/- ##
==========================================
- Coverage 81.91% 81.56% -0.35%
==========================================
Files 106 107 +1
Lines 22386 22487 +101
Branches 22386 22487 +101
==========================================
+ Hits 18337 18342 +5
- Misses 3536 3632 +96
Partials 513 513 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Conformance comparison report
Number passing in both: 5603 Number failing in both: 826 Number passing in Base (eb01344) but now fail: 0 Number failing in Base (eb01344) but now pass: 0 |
jpschorr
force-pushed
the
feat-plan-gpml
branch
from
bdc9ad3 to
d3f90a8
Compare
alancai98
approved these changes
Mar 25, 2025
| @@ -2435,301 +2435,4 @@ mod tests { | |||
| assert_eq!(Value::Bag(Box::new(expected)), res); | |||
| } | |||
| } | |||
|
|
|||
| mod graph { | |||
There was a problem hiding this comment.
I assume this is basically the same as what's now in partiql-eval/src/eval/expr/graph_match.rs?
am357
approved these changes
Mar 26, 2025
jpschorr
force-pushed
the
feat-plan-gpml
branch
from
f595ebc to
2bf9bbf
Compare
This was referenced Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
SimpleGraph; minimal graph needed to read experimental tests #546 into anEvalExprrather than aBindOp(REXrather than aRELin PartiQL plan lingo)SimpleGraph; minimal graph needed to read experimental tests #546Graphtyping supportBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.