Skip to content

[WIP] use Parthenon::AllReduce #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[WIP] use Parthenon::AllReduce #147

wants to merge 1 commit into from

Conversation

@BenWibking
Copy link
Contributor

Use parthenon::AllReduce instead of MPI_AllReduce.

@pgrete
Copy link
Contributor

pgrete commented Oct 6, 2025

What's the plan with this PR?
It'd be great to have proper allreduces that work with num_packs != 1.

@BenWibking
Copy link
Contributor Author

I think there was one additional fix to get this working that I only added to the precipitator branch. If I can find that, could you test this PR and take it from there?

@pgrete
Copy link
Contributor

pgrete commented Oct 6, 2025

Yes, sounds like a plan. I'll also finalize #146 (as all tests worked) so that we have a more up to date Parthenon version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BenWibking @pgrete