-
Couldn't load subscription status.
- Fork 25
Tracers: flux-based advection and dynamical injection #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mfournier01
wants to merge
93
commits into
main
Choose a base branch
from
mfournier01/tracer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filled in values for s_i
small edits in the par_reduce in the computation of the correlations
fixed a bug in computing the correlations
731d506 to
6f97fc7
Compare
c10663f to
f0af06c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main modifications are:
AdvectTracerroutine into two separate methods. Method 0 corresponds to the already implemented velocity field interpolation method. Method 1 is the new flux-based method. The method can be specified in the input file within the<tracer>section, using themethodparameter.A comparison of the two methods is presented below, and can be compared to Fig. 9 from https://ui.adsabs.harvard.edu/abs/2013MNRAS.435.1426G/abstract.
hydro_density.mp4
A 2D test using the Kelvin-Helmholtz and method 1 is also presented below.
hydro_density.mp4