Skip to content
This repository was archived by the owner on Jul 29, 2022. It is now read-only.

Update deps && bump minor version #6

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Update deps && bump minor version #6

wants to merge 5 commits into from

Conversation

kpp
Copy link

@kpp kpp commented Jun 24, 2021

This is a breaking change for those who are using the rustls feature, so the minor version has been bumped.

@kpp kpp requested a review from drahnr June 24, 2021 15:04
@kpp kpp marked this pull request as draft June 24, 2021 15:10
@kpp kpp marked this pull request as ready for review June 24, 2021 15:23
@burdges
Copy link

burdges commented Jun 24, 2021

I doubt this causes problems.. https://crates.io/crates/x509-signature/reverse_dependencies

@DemiMarie
Copy link

@kpp please note that this repository is no longer maintained. Contributions should be made to my fork.

@drahnr
Copy link

drahnr commented Jun 25, 2021

To me this looks ok, depending on the particular use case picky might be a good alternative in the long run, since this is not maintained anymore. To be discussed internally. The changes themselves look good to me.

@DemiMarie
Copy link

To me this looks ok, depending on the particular use case picky might be a good alternative in the long run, since this is not maintained anymore. To be discussed internally. The changes themselves look good to me.

The reason this is not maintained is that I no longer work at Parity. I will review any PRs made to my fork at https://github.com/DemiMarie/x509-signature.

@kpp kpp marked this pull request as draft June 25, 2021 11:29
@kpp
Copy link
Author

kpp commented Jun 25, 2021

Wait, CI does not check --feature webpki, so I have to patch the code a little bit more.

Copy link

@DemiMarie DemiMarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@kpp kpp marked this pull request as ready for review June 25, 2021 13:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants