Skip to content

[pallet-revive] revm tests scaffolding #9290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: pg/revm
Choose a base branch
from
Open

[pallet-revive] revm tests scaffolding #9290

wants to merge 13 commits into from

Conversation

xermicus
Copy link
Member

@xermicus xermicus commented Jul 22, 2025

This PR implements the pallet-revive EVM integration tests.

  • Refactors VM specific tests into dedicated modules.
  • Adds the shared VM tests.
  • Adds the solidity-fixtures crate
    • Helper script (simply bash fixturs-solidity/build_fixtures.sh) to regenarte.
    • Fixtures are checked in for now and to be update manually. Is a KISS solution: Trivial, doesn't annoy other devs, doesn't fail the CI, works regardless whether the crate is used within the workspace or not.

xermicus and others added 11 commits July 22, 2025 15:01
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Signed-off-by: xermicus <cyrill@parity.io>
Signed-off-by: xermicus <cyrill@parity.io>
Signed-off-by: xermicus <cyrill@parity.io>
Signed-off-by: xermicus <cyrill@parity.io>
@pgherveou
Copy link
Contributor

Fixtures are checked in for now and to be update manually. I think it is not even a bad solution: Trivial, doesn't annoy other devs, doesn't fail the CI, works regardless whether the crate is used within the workspace or not.

I am fine with that
alternatively we have solc / resolc in CI now
https://github.com/paritytech/devops/issues/4193#issuecomment-3103595783

since you moved fixture in it's own repo, having a build.rs that build when they are touched, wouldn't be the end of the world.

@xermicus
Copy link
Member Author

To have them built when they are touched they should live in the target directory right?

Signed-off-by: xermicus <cyrill@parity.io>
@xermicus xermicus added R0-no-crate-publish-required The change does not require any crates to be re-published. T7-smart_contracts This PR/Issue is related to smart contracts. labels Jul 23, 2025
@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/16491913902
Failed job name: fmt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-no-crate-publish-required The change does not require any crates to be re-published. T7-smart_contracts This PR/Issue is related to smart contracts.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants