Replace log with tracing on Bridge-related modules
#9279
+788
−786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymondkfcheung
changed the title
log with tracing on Bridge-related modules
17 tasks
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
karolk91
reviewed
Jul 24, 2025
bridges/modules/beefy/src/utils.rs
Outdated
| authority, | ||
| sig, | ||
| ?sig, | ||
| "Signed commitment contains incorrect signature of validator {idx} ({authority:?})" |
There was a problem hiding this comment.
I propose to make also {idx} and ({authority:?} a structured params
# Conflicts: # bridges/modules/grandpa/src/call_ext.rs # bridges/modules/grandpa/src/lib.rs
# Conflicts: # bridges/modules/messages/src/lib.rs # bridges/modules/messages/src/migration.rs # bridges/modules/messages/src/outbound_lane.rs
# Conflicts: # bridges/modules/parachains/src/call_ext.rs # bridges/modules/parachains/src/lib.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces
logwithtracinginstrumentation in Bridge-related modules by providing structured logging.Partially addresses #9211
Similar to #8732
Key Features
bridge::*log targets?variable/%variablesyntax for automaticDebug/Displayformatting