Skip to content

implement InspectMessageQueues for UnpaidRemoteExporter #9250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

acatangiu
Copy link
Contributor

Add missing implementation of InspectMessageQueues for UnpaidRemoteExporter

@acatangiu acatangiu self-assigned this Jul 17, 2025
@acatangiu acatangiu requested a review from a team as a code owner July 17, 2025 14:13
@acatangiu acatangiu added T6-XCM This PR/Issue is related to XCM. A4-backport-stable2506 Pull request must be backported to the stable2506 release branch A4-backport-unstable2507 Pull request must be backported to the unstable2507 release branch labels Jul 17, 2025
@acatangiu
Copy link
Contributor Author

/cmd prdoc --audience runtime_dev --patch

Comment on lines +339 to +340
/// This router needs to implement `InspectMessageQueues` but doesn't have to
/// return any messages, since it just reuses the `XcmpQueue` router.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, not related to this PR, but I still can't wrap my head around this. I had issues understanding this in the past as well: https://github.com/paritytech/polkadot-sdk/pull/5913/files#r1793479596

Is this behavior a property of the implementation of UnpaidRemoteExporter or a property of the fact that the final Router is XcmpQueue ? And can we rely on the fact that the final Router is always XcmpQueue ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually approving this PR since my concern is unrelated, and I'll think some more about this issue later. I'll open a separate PR if I find a different approach.

Comment on lines +339 to +340
/// This router needs to implement `InspectMessageQueues` but doesn't have to
/// return any messages, since it just reuses the `XcmpQueue` router.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually approving this PR since my concern is unrelated, and I'll think some more about this issue later. I'll open a separate PR if I find a different approach.

description: Add missing implementation of `InspectMessageQueues` for `UnpaidRemoteExporter`
crates:
- name: staging-xcm-builder
bump: patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
bump: patch
bump: minor

@karolk91
Copy link
Contributor

Is there some trait bound missing for InspectMessageQueues ? to make sure it would result in compile time error in case other types are also missing this impl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A4-backport-stable2506 Pull request must be backported to the stable2506 release branch A4-backport-unstable2507 Pull request must be backported to the unstable2507 release branch T6-XCM This PR/Issue is related to XCM.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants