-
Notifications
You must be signed in to change notification settings - Fork 982
implement InspectMessageQueues for UnpaidRemoteExporter #9250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
/cmd prdoc --audience runtime_dev --patch |
…time_dev --patch'
/// This router needs to implement `InspectMessageQueues` but doesn't have to | ||
/// return any messages, since it just reuses the `XcmpQueue` router. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, not related to this PR, but I still can't wrap my head around this. I had issues understanding this in the past as well: https://github.com/paritytech/polkadot-sdk/pull/5913/files#r1793479596
Is this behavior a property of the implementation of UnpaidRemoteExporter
or a property of the fact that the final Router
is XcmpQueue
? And can we rely on the fact that the final Router
is always XcmpQueue
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually approving this PR since my concern is unrelated, and I'll think some more about this issue later. I'll open a separate PR if I find a different approach.
/// This router needs to implement `InspectMessageQueues` but doesn't have to | ||
/// return any messages, since it just reuses the `XcmpQueue` router. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually approving this PR since my concern is unrelated, and I'll think some more about this issue later. I'll open a separate PR if I find a different approach.
description: Add missing implementation of `InspectMessageQueues` for `UnpaidRemoteExporter` | ||
crates: | ||
- name: staging-xcm-builder | ||
bump: patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bump: patch | |
bump: minor |
Is there some trait bound missing for |
Add missing implementation of
InspectMessageQueues
forUnpaidRemoteExporter