-
Notifications
You must be signed in to change notification settings - Fork 1
WIP: Remove force push to Pantheon by preparing local history #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 0.x
Are you sure you want to change the base?
Conversation
…s the one being used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't merge this PR until figuring out if #46 is working
Thanks @stevector-streaming. Yes, I had to correctly require the branch before Composer / the Terminus plugin manager would use the This build on the main branch of our personal site did not include the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @stevector for figuring out the issue with #46.
I saw yesterday that Miriam's sample repo does use force pushing still. That reduces the urgency for me to get force pushing out. Also, I'm finding that getting it out in a way that accommodates all the permutations of repo patterns is even trickier than I anticipated (and I was expecting it to be tricky). I'd like to defer this work until we have a more coherent plan for the future of Build Tools. |
Setting back to Draft based on the last comment and failing deployments. |
This pull request removes the Git force push behavior.
--no-git-force
to the invocation ofterminus -n build:env:create
.scripts/prepare-repo.sh
Here are site that consume this action that are working with this change:
Before merging this PR, someone else should check that it works on their own consuming repo.